-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usings
to names in REPL completions.
#42094
Conversation
Actually, @aviatesk - i'm not sure if this PR is right... Can you expand on what you meant in your comment?: What are situations that don't work like you expect, and how would you want them to change? I'm going to downgrade this PR to a draft, since i'm not sure what the desired behavior actually is... please feel free to commit directly to the PR and change it however you'd like!! 😁 |
Merge? |
append!(suggestions, filtered_mod_names(p, mod, name, true, true)) | ||
else | ||
append!(suggestions, filtered_mod_names(p, mod, name, true, false)) | ||
# special case `Core` and `Base` bindings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these not show up via usings=true normally? I guess I don't really know how names works
Note that this doesn't merge into master, but into that other PR (which should be merged first instead) |
I was about to open an issue, but I guess this falls under the same? module A
module B
struct C end
end
end
julia> import .A.B.<tab>┌ Error: Error in the keymap
│ exception =
│ UndefVarError: `out` not defined
│ Stacktrace: (Works fine on 1.9 though) Full stack trace and versioninfo
|
That's a separate issue. We need to backport #53273 to v1.10. |
e0ac286
to
6abca30
Compare
66b9235
to
81e006d
Compare
a0c1f2b
to
073b98c
Compare
81e006d
to
5992e94
Compare
073b98c
to
d5b0b9c
Compare
5992e94
to
322adfd
Compare
322adfd
to
6dfdc91
Compare
Add
usings
to names in REPL completions.Follow up to #42092, rest of #36529.
This enables the REPL to use the names imported via
usings
in completions.