atomics: optimize atomic modify operations (mostly) #42017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
reviewed
Aug 27, 2021
Lacking inlining, but now expressing the direct invoke: this gets us within about 2x of a primitive atomicrmw add.
vtjnash
force-pushed
the
jn/optimize-atomics-3
branch
from
de09a23 to
85518c8
Compare
|
Should this also be backported (like the other atomic PRs) |
63 tasks
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the series of operations from #41859, this now gets us very close to the performance of the old Atomic type (within 2x, measured), but with far greater flexibility and features.