Skip to content

Mark the Sockets "eof test" as broken on FreeBSD #41983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DilumAluthge wants to merge 3 commits into from
Closed

Mark the Sockets "eof test" as broken on FreeBSD #41983

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af98e8d
Mark the Sockets "eof test" as broken on FreeBSD
DilumAluthge Aug 24, 2021
2ab9a1b
Apply suggestions from code review
DilumAluthge Aug 24, 2021
9f6f569
Use the concise one-liner suggested by Mosè
DilumAluthge Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion stdlib/Sockets/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,12 @@ end
@test readuntil(P, 'w') == "llo"
Sys.iswindows() && wait(t)
@test eof(P)
@test !isopen(P) # eof test should have closed this by now
if Sys.isfreebsd()
# FIXME: eof test should have closed this by now, but it seems not to on FreeBSD 12
Comment thread
DilumAluthge marked this conversation as resolved.
Outdated
@test_broken !isopen(P)
else
@test !isopen(P) # eof test should have closed this by now
end

@giordano giordano Aug 24, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is equivalent to

@test !isopen(P) broken=Sys.isfreebsd()

close(P) # should be a no-op, just make sure
@test !isopen(P)
@test eof(P)
Expand Down