Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature detection for ARM/MacOS #41924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature detection for ARM/MacOS #41924
Changes from 9 commits
223ae7e
5f731c5
5c4e7f4
0b165f0
efe722c
8295ffb
399d22c
2fddfba
ed30203
9e3ffe8
d96e2ed
a3f5904
4ecb98d
498bac7
b44c8e2
6271618
aec01a6
98c9fa6
b41771d
ee77b8a
0053128
71d21f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should try to reuse this code and should instead replace the whole function (
_get_host_cpu
).But if you do, you should use the M1 info, i.e.
0x23
.