Fix ~50 invalidations stemming from modules_to_be_loaded
#41878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
approved these changes
Aug 13, 2021
5 tasks
vtjnash
reviewed
Aug 16, 2021
timholy
force-pushed
the
teh/inval_mods_loaded
branch
from
f977b9f
to
624d5c4
Compare
ChainRulesCore defines `==(a, b::AbstractThunk)` and its converse, and these end up invaliding parts of the REPL (including `eval_user_input`) via inference failures in `modules_to_be_loaded`. Co-authored by: Jameson Nash <[email protected]>
timholy
force-pushed
the
teh/inval_mods_loaded
branch
from
624d5c4
to
3318eeb
Compare
|
This doubles-down on Jameson's "better to check in the caller" comment and just removes support for anything other than |
|
I think so. The test coverage should already be representative of the original spec, so if there are gaps outside of Expr it seems better to be additive. So 👍 |
KristofferC
pushed a commit
that referenced
this pull request
Aug 25, 2021
ChainRulesCore defines `==(a, b::AbstractThunk)` and its converse, and these end up invaliding parts of the REPL (including `eval_user_input`) via inference failures in `modules_to_be_loaded`. Co-authored by: Jameson Nash <[email protected]> (cherry picked from commit 7a6336d)
63 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…#41878) ChainRulesCore defines `==(a, b::AbstractThunk)` and its converse, and these end up invaliding parts of the REPL (including `eval_user_input`) via inference failures in `modules_to_be_loaded`. Co-authored by: Jameson Nash <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…#41878) ChainRulesCore defines `==(a, b::AbstractThunk)` and its converse, and these end up invaliding parts of the REPL (including `eval_user_input`) via inference failures in `modules_to_be_loaded`. Co-authored by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainRulesCore defines
==(a, b::AbstractThunk)and its converse,and these end up invaliding parts of the REPL (including
eval_user_input)via inference failures in
modules_to_be_loaded.CC @ChrisRackauckas