Skip to content

Revert "add stream shutdown and support half-duplex operation"#41808

Merged
DilumAluthge merged 1 commit intorevert-41710-jn/uv2-1.42.0from
revert-40783-jn/shutdown
Aug 6, 2021
Merged

Revert "add stream shutdown and support half-duplex operation"#41808
DilumAluthge merged 1 commit intorevert-41710-jn/uv2-1.42.0from
revert-40783-jn/shutdown

Conversation

@ararslan
Copy link
Copy Markdown
Member

@ararslan ararslan commented Aug 6, 2021

Reverts #40783. This broke FreeBSD support by causing the Sockets tests to fail. In particular, in https://github.com/JuliaLang/julia/blob/master/stdlib/Sockets/test/runtests.jl#L524, the pipe was not closed automatically so isopen(P) is still true.

@ararslan ararslan requested a review from vtjnash August 6, 2021 20:50
@ararslan ararslan changed the base branch from master to revert-41710-jn/uv2-1.42.0 August 6, 2021 21:00
@DilumAluthge
Copy link
Copy Markdown
Member

There's a bit of a backlog on tester_freebsd, so it might take a while before the tester_freebsd job starts on this PR.

@DilumAluthge DilumAluthge merged commit d15a330 into revert-41710-jn/uv2-1.42.0 Aug 6, 2021
@DilumAluthge DilumAluthge deleted the revert-40783-jn/shutdown branch August 6, 2021 23:26
DilumAluthge pushed a commit that referenced this pull request Aug 7, 2021
DilumAluthge pushed a commit that referenced this pull request Aug 7, 2021
DilumAluthge pushed a commit that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants