Allow exponentiation of Diagonal{*Range}
#40991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcabbott Would you mind taking a quick look? |
mcabbott
reviewed
May 30, 2021
There was a problem hiding this comment.
This looks fine to me, the original issue for Diagonal(1:3)^2 was within power_by_squaring, but it seems better to catch this earlier and never go there.
Things like Diagonal(1:3)^4.5 already had a special path, but this seems cleaner.
julia/stdlib/LinearAlgebra/src/dense.jl
Line 492 in 93d375c
Co-authored-by: Michael Abbott <[email protected]>
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
Co-authored-by: Michael Abbott <[email protected]>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Co-authored-by: Michael Abbott <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40886.