-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
range: Assume start=1 when not given. Use OneTo #39223
Closed
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
314f3fd
range: Assume start=1 when not given. Use OneTo
mkitti 8b8718c
range: Document single positional argument as stop
mkitti 9443922
NEWS.md for range: `start=1`, one pos arg as stop
mkitti ea5e281
Fix typo in ranges.jl test
mkitti 5566ec1
Clarify documentation
mkitti a63eead
range: Address test failures
mkitti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this accurate and succinct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a good question. Can we simplify the documentation?
I'm wary of saying "The omitted parameter is computed" because someone may think additional processing occurs that may take time. In some cases, no additional computation is actually done unless the value of the parameter is actually requested. The preceding paragraph states "Mathematically a range is uniquely determined by any three of
start
,step
,stop
and `length". That covers what needs to be said well. I would keep the first bullet point as is.For the second bullet point,
If
stop
andlength
are specified, then onlystep
is assumed to be one. We could have assumedstart
to be one, but that would have a distinct result. We at least need to saystep
is assumed to be one first.How about this:
range
with fewer than three parameters. Eitherstop
orlength
must be specified. If not provided,step
and/orstart
are assumed to be one in that order of precedence.