Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arrows to the punctuation list. #35990

Merged
merged 5 commits into from
May 28, 2020
Merged

Add arrows to the punctuation list. #35990

merged 5 commits into from
May 28, 2020

Conversation

nathanrboyer
Copy link
Contributor

My first time using Github. I don't know what I'm doing.

@nathanrboyer
Add arrow punctuation to the list.
d11aef5 
My first time using Github. I don't know what I'm doing.
@nathanrboyer
Update punctuation.md
d1ccf70
mbauman
mbauman reviewed May 22, 2020
View reviewed changes
Copy link
Member

@mbauman mbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, welcome to GitHub! This looks just about right, but needs a bit of fiddling to make the @refs hit their targets as you want. I don't think we have an @ref target for -> since it's not a first-class object (and is indeed just syntax).

doc/src/base/punctuation.md Outdated Show resolved Hide resolved
@nathanrboyer @mbauman
Update doc/src/base/punctuation.md
a351b34 
Thanks for your help!

Co-authored-by: Matt Bauman <[email protected]>
@ViralBShah ViralBShah added the docs This change adds or pertains to documentation label May 24, 2020
@ViralBShah ViralBShah merged commit 8068e76 into JuliaLang:master May 28, 2020
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
@nathanrboyer @mbauman @simeonschaub
Add arrows to the punctuation list. (JuliaLang#35990)
98da056 
* Add arrow punctuation to the list.

My first time using Github. I don't know what I'm doing.

* Update punctuation.md

* Update doc/src/base/punctuation.md

Thanks for your help!

Co-authored-by: Matt Bauman <[email protected]>

* Update doc/src/base/punctuation.md

Co-authored-by: Matt Bauman <[email protected]>

* Removed all end of line periods for consistency.

Co-authored-by: Matt Bauman <[email protected]>
@nathanrboyer nathanrboyer deleted the patch-1 branch December 7, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffevotte ffevotte ffevotte left review comments

@mbauman mbauman mbauman left review comments

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathanrboyer @mbauman @ffevotte @ViralBShah