Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum/maximum over dimensions with missing values #35323

Merged
merged 4 commits into from
Dec 10, 2023
Merged

Commits on Nov 14, 2023

  1. Fix minimum/maximum over dimensions with missing values for BigInt

    Types such as `BigInt` don't support `typemin` and `typemax` so
    the current method to find an initial value different from `missing` fails.
    Use the largest/smallest non-missing value to initialize the array instead.
    This is an inefficient approach. Faster alternatives would be to avoid using
    an initial value at all, and instead keep track of whether a value has been
    set in a separate mask; or to use `typemax`/`typemin` for types that support them.
    nalimilan committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    a2adce0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Better fix

    nalimilan committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    dbb6f49 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Configuration menu
    Copy the full SHA
    b93a942 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Configuration menu
    Copy the full SHA
    46a9466 View commit details
    Browse the repository at this point in the history