Merge pull request #34483 from JuliaLang/sf/python_search #34483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this need to be backported to the 1.4 branch? (cf https://build.julialang.org/#/builders/64/builds/8940). |
|
Yes, I think this is good for backporting. I've also manually patched the environments to have a |
26 tasks
staticfloat
force-pushed
the
sf/python_search
branch
from
f3944e7
to
181050b
Compare
staticfloat
changed the title
python, python3 or python2
|
Can skip the merge commit for PRs like this. |
|
You mean by using "rebase" when I merge? |
|
When there's only one commit, just squash it and the result is no merge commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributions, more and more, are starting to drop
python2completely as it's officially EOL'ed now. Some distributions don't like thatpythoncan mean eitherpython2orpython3, so they provide onlypython3by default. For things likenormalize_triplet.py, we don't really care what version of python is being used, we just want any of them. So we setPYTHONas the result of looking around a bit for the best choice.