-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASAN fixes #34389
ASAN fixes #34389
Conversation
I'm confused why the datalayout commit is necessary. All of these have nfields set to zero, so it should never attempt to load any pointer past the end of the declared struct. Which code is doing this reading? |
The number of pointers isn't set to 0, so this adds one: Lines 873 to 874 in 08ebedc
|
I think the idea was that if first_ptr is |
Ah, OK. Yeah, that wasn't clear to me at all. I'll have a look at avoiding those reads then. |
I don't really get the layout code (i.e. the specific semantics of nfields/npointers/first_ptr, @vtjnash?), so I just implemented #34389 (comment). |
No description provided.