Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #32620, crash when assigning to static parameter #32623

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Conversation

JeffBezanson
Copy link
Member

In version 1.0 (and some prior versions) we gave a warning for any local variable with the same name as a static parameter. Then #30184 changed that to an error, but only in some cases. This rationalizes things by covering all cases with either (1) giving an error, or (2) allowing explicit shadowing with let.

fixes #32620

@JeffBezanson JeffBezanson added compiler:lowering Syntax lowering (compiler front end, 2nd stage) bugfix This change fixes an existing bug labels Jul 18, 2019
@JeffBezanson JeffBezanson merged commit b9b099f into master Jul 20, 2019
@JeffBezanson JeffBezanson deleted the jb/fix32620 branch July 20, 2019 15:19
@KristofferC
Copy link
Member

Adding backport since it fixes a bug on rc-2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:lowering Syntax lowering (compiler front end, 2nd stage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault in Julia 1.2.0-rc2.0 on assigning to a static parameter in a while loop
2 participants