Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch world age fields to ulong #32241

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Switch world age fields to ulong #32241

merged 1 commit into from
Jun 7, 2019

Conversation

Keno
Copy link
Member

@Keno Keno commented Jun 4, 2019

They are declared as size_t in the header, which is unsigned.

Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also base/reflection.jl accessors, and probably need to fix Serializer to be compatible. But otherwise, lgtm if it passes on CI.

@Keno
Copy link
Member Author

Keno commented Jun 5, 2019

and probably need to fix Serializer to be compatible

Are you thinking we need to write custom serializers/deserializers for every type we're changing here? I'm not really sure how feasible that is. CodeInstance wasn't even a thing in earlier 1.0 instances. Also world ages should never really have been serialized in the first place, since they won't be meaningful after a reload.

@Keno
Copy link
Member Author

Keno commented Jun 5, 2019

So @JeffBezanson @vtjnash any guidance on what needs to change in the Serializer?

They are declared as `size_t` in the header, which is unsigned.
@Keno Keno merged commit ad42d5d into master Jun 7, 2019
@fredrikekre fredrikekre deleted the kf/ulong branch June 7, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants