Make it possible to avoid the warning when replacing docstrings #32118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that
doc!
always warns led Revise to skipdoc!
calls but that led to a bug, timholy/Revise.jl#309. The fix in timholy/Revise.jl#310 basically requires copy-pasting the definition ofdoc!
, which seems like a bad idea. This just adds an extra optional argument that allows one to suppress generation of the warning. Non-breaking but probably not advisable to backport since it's a new feature.EDIT: alternatively this could be a keyword argument.