Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transitive comparison of floats and rationals #3110

Merged
merged 4 commits into from
May 15, 2013
Merged

transitive comparison of floats and rationals #3110

merged 4 commits into from
May 15, 2013

Commits on May 15, 2013

  1. Float{64,32} == Rational: implement exact equality checking [#3102] 

    This is a fairly insane way to do this, but it works robustly. Even
works for Rational{BigInt}, which I really need to add checks for,
along with all the other functionality.

Temporarily disable some tests in test/numbers.jl until I can sort
out what they ought to check, if anything.
    @StefanKarpinski
    StefanKarpinski committed May 15, 2013
    3 Configuration menu
    Copy the full SHA
    d2b964d View commit details
    Browse the repository at this point in the history

  2. simpler transitive Float == Rational equality implementation [#3102].

    @StefanKarpinski
    StefanKarpinski committed May 15, 2013
    Configuration menu
    Copy the full SHA
    db0cd95 View commit details
    Browse the repository at this point in the history

  3. re-enable all tests in numbers (with slight modification).

    @StefanKarpinski
    StefanKarpinski committed May 15, 2013
    Configuration menu
    Copy the full SHA
    d8615d7 View commit details
    Browse the repository at this point in the history

  4. add some tests for new float-rational comparisons.

    @StefanKarpinski
    StefanKarpinski committed May 15, 2013
    Configuration menu
    Copy the full SHA
    bdc2034 View commit details
    Browse the repository at this point in the history