use non Pkg for workflow tips #30194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
approved these changes
Nov 29, 2018
Member
StefanKarpinski
left a comment
StefanKarpinski
left a comment
There was a problem hiding this comment.
Does seem like a simplification and an improvement.
KristofferC
added a commit
that referenced
this pull request
Dec 12, 2018
(cherry picked from commit 560e829)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28725 changed the workflow tips to use Pkg. I think that was a significant step up in complexity when all that was really needed here is to change a
using Tmptousing .Tmpetc. I therefore just changed the original example to work again, with some small tweaks to it.