fix a transitivity error in method specificity #29405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
types and dispatch
JeffBezanson
added
the
minor change
|
This changes method sort order, albeit in a fairly minor way. I'll merge it now so we can see how it goes. |
perrutquist
added a commit
to perrutquist/StaticNumbers.jl
that referenced
this pull request
Oct 17, 2018
The code stopped working after JuliaLang/julia#29405 The reasons are unclear, but this change will make it work, and there's always the option to make `Static(x) = static(x)` in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this while working on #29269. It doesn't seem to cause much of a problem now, because the corresponding type intersections are (incorrectly) empty. However this is required for the #29269 fix to avoid generating fairly bad ambiguity problems.