Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Performance improvement to iterate of StepRange{<:TimeType} #29404

Merged
merged 1 commit into from
Oct 18, 2018
Merged

[WIP] Performance improvement to iterate of StepRange{<:TimeType} #29404

merged 1 commit into from
Oct 18, 2018

Conversation

kcajf
Copy link
Contributor

@kcajf kcajf commented Sep 27, 2018

Addresses #29403

@kcajf kcajf changed the title Performance improvement to iterate of StepRange{<:TimeType} [WIP] Performance improvement to iterate of StepRange{<:TimeType} Oct 10, 2018
@quinnj quinnj mentioned this pull request Oct 11, 2018
Closed
quinnj
quinnj approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me given the feedback in #29403

@kcajf
Copy link
Contributor Author

kcajf commented Oct 11, 2018

Great, thanks Jacob.

@kcajf
Copy link
Contributor Author

kcajf commented Oct 18, 2018

What's the last step needed to get this merged in? Just a hit of a button?

@KristofferC KristofferC merged commit 5f2759d into JuliaLang:master Oct 18, 2018
@KristofferC KristofferC mentioned this pull request Dec 13, 2018
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kcajf @quinnj @KristofferC @TechnophobicLampshade