Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndigits with negative base: error out instead of giving incorrect result #29148

Merged
merged 2 commits into from
Sep 13, 2018
Merged

ndigits with negative base: error out instead of giving incorrect result #29148

merged 2 commits into from
Sep 13, 2018

Commits on Sep 12, 2018

  1. ndigits with negative base: error out instead of giving incorrect result 

    Because of an unchecked conversion via `signed` (instead of `Signed`),
we were giving wrong results, e.g. we had
`ndigits(typemax(UInt), base=-2) != ndigits(big(typemax(UInt)), base=-2)`
    @rfourquet
    rfourquet committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    d8e001f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. we might as well give a correct answer! (StefanKarpinski)

    @rfourquet
    rfourquet committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    d2c92b8 View commit details
    Browse the repository at this point in the history