Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logic in getfield_nothrow to allow removing more getfields #29084

Merged
merged 1 commit into from
Sep 8, 2018
Merged

fix logic in getfield_nothrow to allow removing more getfields #29084

merged 1 commit into from
Sep 8, 2018

Conversation

JeffBezanson
Copy link
Sponsor Member

The existing code unintentionally returned false for every constant unless it was a module.

@JeffBezanson JeffBezanson added the compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) label Sep 7, 2018
@Keno Keno merged commit 42e8920 into master Sep 8, 2018
@martinholters martinholters deleted the jb/getfield_nothrow_fix branch September 8, 2018 20:31
@KristofferC KristofferC mentioned this pull request Sep 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
compiler:optimizer Optimization passes (mostly in base/compiler/ssair/)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeffBezanson @Keno @KristofferC