Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detangle Slice and fix mixed-dimension in-place reductions #28941

Merged
merged 4 commits into from
Dec 1, 2018

Commits on Sep 11, 2018

  1. Detangle Slice between whole dimensions and axes

    We use axes in many downstream computations that may not re-index directly into the original array, so we add a second type parameter to `Slice` that is turned on when converting `:` in indexing expressions -- and really only `SubArray` cares about.
    mbauman committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    1e0d847 View commit details
    Browse the repository at this point in the history
  2. Reduce allocations for in-place reductions and fix mixed-dimensionali…

    …ty edge-cases
    
    Alleviates #28928 but does not completely remove allocations due to the allocation of the view that gets passed to `map!`.
    mbauman committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    6d0e354 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Introduce a whole new IdentityUnitRange

    that we will encourage offset array implementations to use instead of Base.Slice
    mbauman committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    7702adc View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2018

  1. Configuration menu
    Copy the full SHA
    d154e83 View commit details
    Browse the repository at this point in the history