Fix missing gc root in jl_cglobal #28747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static analysis complains that the jl_fieldref could allocate, which then gets passed to jl_bitcast unrooted. I believe it's right about that. While we're here, also fix what I believe is a typo (`ty` vs `v`).
yuyichao
approved these changes
Aug 18, 2018
|
Which error case are you referring to? |
|
I mean (currently) if the input type is valid (string/symbol), |
|
Hm, but doesn't the problematic case there explicitly allow it to be a pointer? |
|
Yes, it looks like the order of checks here is wrong. Its not supposed to accept a 1-tuple of a pointer |
Merged
|
Ok, we can switch around the conditional and use the non-allocating fieldref version then. |
KristofferC
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static analysis complains that the jl_fieldref could allocate,
which then gets passed to jl_bitcast unrooted. I believe it's
right about that.
While we're here, also fix what I believe is a typo (
tyvsv).