Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code font for jl_value_t in h2 #28702

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Use code font for jl_value_t in h2 #28702

merged 1 commit into from
Aug 16, 2018

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 16, 2018

By just using text, the underscores around value are interpreted as begin/end italics.

See:

screenshot from 2018-08-16 10-08-27

By just using text, the underscores around value are interpreted as begin/end italics.
@ararslan ararslan added the docs This change adds or pertains to documentation label Aug 16, 2018
@fredrikekre fredrikekre merged commit 1fee8a4 into JuliaLang:master Aug 16, 2018
@fredrikekre
Copy link
Member

Thanks for the fix, and welcome as a contributor to Julia!

@dhermes dhermes deleted the patch-1 branch August 17, 2018 04:47
@dhermes
Copy link
Contributor Author

dhermes commented Aug 17, 2018

Cheers!

KristofferC pushed a commit that referenced this pull request Aug 19, 2018
By just using text, the underscores around value are interpreted as begin/end italics.

(cherry picked from commit 1fee8a4)
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
By just using text, the underscores around value are interpreted as begin/end italics.

(cherry picked from commit 1fee8a4)
@KristofferC KristofferC mentioned this pull request Aug 19, 2018
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
By just using text, the underscores around value are interpreted as begin/end italics.

(cherry picked from commit 1fee8a4)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
By just using text, the underscores around value are interpreted as begin/end italics.

(cherry picked from commit 1fee8a4)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
By just using text, the underscores around value are interpreted as begin/end italics.

(cherry picked from commit 1fee8a4)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
By just using text, the underscores around value are interpreted as begin/end italics.

(cherry picked from commit 1fee8a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants