Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parallelizing over collections that have non-Int lengths #28651

Merged
merged 6 commits into from
Aug 24, 2018
Merged

Support parallelizing over collections that have non-Int lengths #28651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b3f457
Update macros.jl
sbromberger Aug 14, 2018
aee422a
Update macros.jl
sbromberger Aug 14, 2018
bc103f6
Update distributed_exec.jl
sbromberger Aug 23, 2018
ee54551
Update distributed_exec.jl
sbromberger Aug 23, 2018
16fd2a4
Update distributed_exec.jl
sbromberger Aug 24, 2018
8e7f939
Update distributed_exec.jl
sbromberger Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/Distributed/src/macros.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ end

function preduce(reducer, f, R)
N = length(R)
chunks = splitrange(N, nworkers())
chunks = splitrange(Int(N), nworkers())
all_w = workers()[1:length(chunks)]

w_exec = Task[]
Expand Down
8 changes: 8 additions & 0 deletions stdlib/Distributed/test/distributed_exec.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,6 +1525,14 @@ end
a27933 = :_not_defined_27933
@test remotecall_fetch(()->a27933, first(workers())) === a27933

# PR #28651
for T in (UInt8, Int8, UInt16, Int16, UInt32, Int32, UInt64)
n = @distributed (+) for i in Base.OneTo(T(10))
i
end
@test n == 55
end

# Run topology tests last after removing all workers, since a given
# cluster at any time only supports a single topology.
rmprocs(workers())
Expand Down