Fix throw_complex_domainerror error message for log[1p] #28621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrison
force-pushed
the
jrg/complex_domainerror
branch
from
3c905ee
to
ee02934
Compare
fredrikekre
approved these changes
Aug 13, 2018
fredrikekre
added
error handling
|
Would you be willing to add some tests that would have caught this? |
The doctests would have caught this had the error not been propagated there, and they will detect any regressions now that the examples have been corrected. I can also change Is there something else you had in mind? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems pretty clearly unintentional. Relevant history is in d4229be and d555a9a.