Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue 28553, improves error message for missing packages #28555

Merged
merged 1 commit into from
Aug 14, 2018
Merged

fixes issue 28553, improves error message for missing packages #28555

merged 1 commit into from
Aug 14, 2018

Conversation

affans
Copy link
Contributor

@affans affans commented Aug 10, 2018

This PR improves the message for missing packages when using using [PkgName] if the package is not installed.

Fixes #28553

@jeremy-ui

This comment has been minimized.

Sign in to view
StefanKarpinski
StefanKarpinski approved these changes Aug 14, 2018
View reviewed changes
Copy link
Sponsor Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping for something less verbose but now that we've chosen not to make Pkg available in the REPL, we pretty much have to do this.

@StefanKarpinski StefanKarpinski merged commit 3d8091f into JuliaLang:master Aug 14, 2018
@affans affans deleted the 28553 branch August 14, 2018 17:44
@affans affans restored the 28553 branch August 14, 2018 17:44
@affans affans deleted the 28553 branch August 14, 2018 17:44
@affans affans restored the 28553 branch August 14, 2018 17:44
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@affans @KristofferC
fixes issue 28553, improves error message for missing packages (#28555)
f9d4dc0 
(cherry picked from commit 3d8091f)
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@affans @KristofferC
fixes issue 28553, improves error message for missing packages (#28555)
035f320 
(cherry picked from commit 3d8091f)
@KristofferC KristofferC mentioned this pull request Aug 19, 2018
Merged
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@affans @KristofferC
fixes issue 28553, improves error message for missing packages (#28555)
2ab3831 
(cherry picked from commit 3d8091f)
@KristofferC KristofferC mentioned this pull request Sep 4, 2018
Closed
@00vareladavid 00vareladavid mentioned this pull request Sep 6, 2018
Closed
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@affans @KristofferC
fixes issue 28553, improves error message for missing packages (#28555)
e69da37 
(cherry picked from commit 3d8091f)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@affans @KristofferC
fixes issue 28553, improves error message for missing packages (#28555)
2417246 
(cherry picked from commit 3d8091f)
@KristofferC KristofferC added docs This change adds or pertains to documentation and removed backport pending 1.0 docs This change adds or pertains to documentation labels Sep 27, 2018
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@affans @KristofferC
fixes issue 28553, improves error message for missing packages (#28555)
5b3404e 
(cherry picked from commit 3d8091f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@affans @jeremy-ui @StefanKarpinski @KristofferC