-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename eps -> ulp #28301
Rename eps -> ulp #28301
Conversation
eps(::Type{T}) where T<:AbstractFloat | ||
eps() | ||
ulp(::Type{T}) where T<:AbstractFloat | ||
ulp() | ||
|
||
Return the *machine epsilon* of the floating point type `T` (`T = Float64` by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't "machine epsilon" be changed (or adjusted to also mention ULP) here as well?
I also don't see any problem in using it for dates or other types — it seems just as easy to define |
I don't like the term "sine" — it's a bad Latin pun arising from an Arabic translation error, and "sin" is literally sinful. I propose that we rename the function to Or we could accept that usage has normalized the term and continue to call this function what everyone else calls it. |
Or |
Another problem with |
I knew |
Same here; if it's that widely used let's just close this. |
My reason for liking the name Regardless, @stevengj is correct that — given that this isn't a unanimous slam dunk — it's far too late to try to squeeze it in now. |
As discussed on triage, this renames
eps
toulp
, because the former is a bit of a pun and even the docstring says this computes theunit in last place
of the given value. Particularly, because we extend this function to things like Dates,eps
is a bit of an awkward name.