Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate stress tests out and run them on node 1 #28270

Merged
merged 3 commits into from
Jul 25, 2018
Merged

Separate stress tests out and run them on node 1 #28270

merged 3 commits into from
Jul 25, 2018

Conversation

ararslan
Copy link
Member

This ensures that they don't interfere with other tests. Suggested by @vtjnash in #28201 (comment). Let me know if any other tests belong here as well.

@ararslan
Separate stress tests out and run them on node 1
42d5194 
This ensures that they don't interfere with other tests.
@ararslan ararslan added the test This change adds or pertains to unit tests label Jul 24, 2018
@ararslan ararslan requested a review from vtjnash July 24, 2018 23:11
vtjnash
vtjnash approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps test_13559 and test_22566 and the test for jl_exit_on_sigint also, if you're looking for more. I assume others will move or be added over time.

@iblislin
Copy link
Member

test_13559 and test_22566 doesn't cause huge workload on pipe. So I hope the file testsuit won't freeze FreeBSD CI builds after this PR merged.

iblislin
iblislin reviewed Jul 25, 2018
View reviewed changes
test/stress.jl Outdated

# issue #22566
# issue #24037 (disabling on FreeBSD)
if !Sys.iswindows() && !(Sys.isbsd() && !Sys.isapple())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to enable it on FreeBSD?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, is it? 😄 If you reenable locally it can you reproducing the freezing it was causing before?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you reenable locally it can you reproducing the freezing it was causing before?

I reenabled it.... seems fine now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for checking, I'll reenable it here.

@ararslan
Copy link
Member Author

macOS test failure is #26725

@ararslan
Reenable the test for #22566 on FreeBSD
314525c 
It was disabled in #24037 but reportedly seems to work okay when
isolated into this separate, node 1 only test group.
@iblislin
Copy link
Member

iblislin commented Jul 25, 2018 •
edited
Loading

I want to build at least 3 times to make sure no freezing again.

@iblislin
Copy link
Member

All builds passed 🎉 🎉

@ararslan
Copy link
Member Author

There were test failures on Travis Linux (both 32- and 64-bit) related to Sockets not being able to connect, so I've restarted those builds to be safe. IIRC we don't run the Sockets tests at all on Circle.

@ararslan
Copy link
Member Author

All good now. I'll go ahead and merge.

@ararslan ararslan merged commit bd44a7a into master Jul 25, 2018
@ararslan ararslan deleted the aa/fd-exhaustion branch July 25, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblislin iblislin iblislin left review comments

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ararslan @iblislin @vtjnash