Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add splitpath(p::AbstractString) to Base.Filesystem. #28156

Merged
merged 16 commits into from
Sep 24, 2018
Merged

Add splitpath(p::AbstractString) to Base.Filesystem. #28156

merged 16 commits into from
Sep 24, 2018

Commits on Sep 24, 2018

  1. Add splitpath(p::AbstractString) to Base.Filesystem. 

    Opposite of `joinpath()`, it separates a path into its parts.
    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    8b04f84 View commit details
    Browse the repository at this point in the history

  2. switch "is root" check to ismount && remove comments since code is … 

    …self-explanatory
    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    734318e View commit details
    Browse the repository at this point in the history

  3. Switch splitpath() to return an Array{String} instead of tuple

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    c46a6cf View commit details
    Browse the repository at this point in the history

  4. s/AbstractString/String/g

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    b122f1f View commit details
    Browse the repository at this point in the history

  5. return type simpliication

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    6105568 View commit details
    Browse the repository at this point in the history

  6. realtimereview: reverse!、splitdir、[tests]

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    990af83 View commit details
    Browse the repository at this point in the history

  7. Attempt to add windows-focused splitpath unittests

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    3bedcab View commit details
    Browse the repository at this point in the history

  8. Fix exports, which should make splitpath exported.

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    2e1a551 View commit details
    Browse the repository at this point in the history

  9. replace ismount with dirname(p) == p check. Also cleanup. 

    Also restructured the while loop a bit to be more readable.
    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    5c8253c View commit details
    Browse the repository at this point in the history

  10. Fixed windows tests: splitpath("C:\\a")->["C:\\", "a"]

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    111748f View commit details
    Browse the repository at this point in the history

  11. Added more corner-case unit tests

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    c3cc1ba View commit details
    Browse the repository at this point in the history

  12. Use pushfirst! not reverse!; switch @test order

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    fe90215 View commit details
    Browse the repository at this point in the history

  13. Added relative path C: drive tests

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    ed17e09 View commit details
    Browse the repository at this point in the history

  14. Fix relative path w/ drive ("C:a"->["C:a"]), and empty path (""->[""]).

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    3205eaf View commit details
    Browse the repository at this point in the history

  15. Fix splitpath broken "C:\\\\a\\b" with _splitdir_nodrive.

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    584d1b3 View commit details
    Browse the repository at this point in the history

  16. Fix docstring output to fix broken doctest

    @NHDaly @StefanKarpinski
    NHDaly authored and StefanKarpinski committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    f8f7088 View commit details
    Browse the repository at this point in the history