Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blockdiag return a 0×0 SparseMatrixCSC{Union{},Int} #28053

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

martinholters
Copy link
Member

Fixes #14850.

@kshyatt kshyatt added the sparse Sparse arrays label Jul 11, 2018
@martinholters
Copy link
Member Author

All CI failures look unrelated:

┌ Error: mktempdir cleanup
│   exception =
│    unlink: resource busy or locked (EBUSY)
│    Stacktrace:
│     [1] uv_error at .\libuv.jl:80 [inlined]

during Pkg test.

  • FreeBSD: httpbin problem.

@andreasnoack
Copy link
Member

Actually, will this cause a type stability issue if the index types of the inputs are non-Ints?

@martinholters
Copy link
Member Author

No, the isempty(X) and the conditional is constant-folded (X is a tuple with length known at compile time). Well, unless the number of arguments is unknown at compile time, but the type instability seems unavoidable then.

@andreasnoack andreasnoack merged commit 56a46e3 into master Jul 12, 2018
@andreasnoack andreasnoack deleted the mh/empty_blockdiag branch July 12, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sparse Sparse arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants