Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cartesian indexing has some overhead:
This is why we set
IndexStyle(a) == IndexLinear()
whenever possible. This PR turns onIndexLinear()
for appropriate (I hope!)ReinterpretArray
s. Demo:That's a 400× improvement. Some of this seems likely to be due to the performance optimizations planned in #27213, but as the example above illustrates, I suspect we'd be seeing some substantial performance gains even if all the LLVM optimizations had been applied.