Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg3: fix adding and developing from url in Windows #27347

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Pkg3: fix adding and developing from url in Windows #27347

merged 2 commits into from
Jun 4, 2018

Conversation

KristofferC
Copy link
Member

Windows throws on isdir with url-like inputs.

@SimonDanisch
Copy link
Contributor

Anything we can do to merge this?

@KristofferC
Copy link
Member Author

Passed on circleci which this would previously fail so should be good to merge.

@KristofferC KristofferC merged commit 4939458 into master Jun 4, 2018
@KristofferC KristofferC deleted the kc/fix_err_win branch June 4, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristofferC @SimonDanisch