Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable unconditional PKG3 precompile #27105

Merged
merged 2 commits into from
May 28, 2018
Merged

enable unconditional PKG3 precompile #27105

merged 2 commits into from
May 28, 2018

Conversation

KristofferC
Copy link
Sponsor Member

Reopens #26431.

This needs to happen at some point so let's look at it again.

@KristofferC
Copy link
Sponsor Member Author

5 greens, wat...

@KristofferC
Copy link
Sponsor Member Author

@staticfloat is it possible to run the buildbots on this commit to try it out?

@vchuravy
Copy link
Member

vchuravy commented May 15, 2018

Elliot is currently busy with his thesis. I will start a series of builds and let you know what the buildbots think about this.

@vchuravy
Copy link
Member

vchuravy commented May 15, 2018

Got an OOM on Win32 (https://build.julialang.org/#/builders/44/builds/1268), but only during make-debug...

@KristofferC
Copy link
Sponsor Member Author

Ok, so the only problem is the Win32 debug build. Seems a lot better than it was a while ago when half of CI crashed.

@KristofferC
Copy link
Sponsor Member Author

Could we just disable it for debug builds?

@KristofferC KristofferC changed the base branch from master to kc/precompile_pkg3_2 May 18, 2018 17:20
@KristofferC KristofferC reopened this May 18, 2018
@KristofferC KristofferC force-pushed the kc/precompile_pkg3_2 branch 2 times, most recently from 7dfe751 to a7b0c54 Compare May 20, 2018 19:08
@KristofferC KristofferC reopened this May 21, 2018
@KristofferC KristofferC changed the base branch from kc/precompile_pkg3_2 to master May 21, 2018 10:57
@KristofferC KristofferC reopened this May 21, 2018
@KristofferC
Copy link
Sponsor Member Author

KristofferC commented May 21, 2018

@KristofferC
Copy link
Sponsor Member Author

Can't get e.g. Win32 to build, it just errors after building OpenBLAS with:

make[1]: Leaving directory '/home/Administrator/buildbot/worker/package_win32/build/deps'
make: *** [Makefile:60: julia-deps] Error 2
program finished with exit code 2
elapsedTime=1937.144804

@kshyatt kshyatt added packages Package management and loading compiler:precompilation Precompilation of modules labels May 27, 2018
@KristofferC
Copy link
Sponsor Member Author

KristofferC commented May 28, 2018

The situation with Pkg3 without precompile statements are now (perhaps the new optimizer) fairly terrible. Just doing status takes up to 6-7 seconds and adding packages is almost back to Pkg2 coffee break times. I have yet managed to get a buildbot run through because it fails on random stuff that doesn't happen with the buildbots when running from master. So the only way to test this seems to be live. I have reduced the number of precompile statements here significantly going from this makes Pkg3 feel good, to this makes Pkg3 not feel like a slow moving piece of sloth.

CircleCI fails because it is running on non rebased version of .circleci where the gcc version was not yet updated.

@KristofferC KristofferC merged commit 2603b57 into master May 28, 2018
@KristofferC KristofferC deleted the kc/precompile_pkg3 branch May 28, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:precompilation Precompilation of modules packages Package management and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants