Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg3: deterministically close the LibGit2 repo in tests #26883

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Pkg3: deterministically close the LibGit2 repo in tests #26883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions stdlib/Pkg3/test/pkg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,14 @@ temp_pkg_dir() do project_path

@testset "legacy CI script" begin
mktempdir() do dir
LibGit2.clone("https://github.com/JuliaLang/Example.jl", joinpath(dir, "Example.jl"))
cd(joinpath(dir, "Example.jl")) do
let Pkg = Pkg3
Pkg.clone(pwd())
Pkg.build("Example")
Pkg.test("Example"; coverage=true)
@test isfile(Pkg.dir("Example", "src", "Example.jl"))
LibGit2.with(LibGit2.clone("https://github.com/JuliaLang/Example.jl", joinpath(dir, "Example.jl"))) do r
cd(joinpath(dir, "Example.jl")) do
let Pkg = Pkg3
Pkg.clone(pwd())
Pkg.build("Example")
Pkg.test("Example"; coverage=true)
@test isfile(Pkg.dir("Example", "src", "Example.jl"))
end
end
end
end
Expand Down