Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate using && and || within at-dot expressions #26792

Merged
merged 2 commits into from
Apr 20, 2018
Merged

Deprecate using && and || within at-dot expressions #26792

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8acfdeb
Deprecate using && and || within at-dot expressions
mbauman Apr 12, 2018
1de31c9
Use nothing instead of () to signify no available frame
mbauman Apr 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions base/broadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,6 +850,11 @@ function __dot__(x::Expr)
Meta.isexpr(x.args[1], :call) # function or macro definition
Expr(x.head, x.args[1], dotargs[2])
else
if x.head == :&& || x.head == :||
Base.depwarn("""
using $(x.head) expressions in @. is deprecated; in the future it will
become elementwise. Break the expression into smaller parts instead.""", ())
Copy link
Sponsor Member

@JeffBezanson JeffBezanson Apr 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still pass some name symbol, maybe :__dot__. Or nothing if absolutely necessary.

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I tried that. The trouble is then the stackframe is identical to every call, leading to only one depwarn. This is a hack that when you pass (), it'll skip the stack frame lookups and just always warn.

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose I could change the hack to look at the symbol and always warn if it starts with @. That's probably better.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then we should use nothing instead of ().

end
head = string(x.head)
if last(head) == '=' && first(head) != '.'
Expr(Symbol('.',head), dotargs...)
Expand Down
2 changes: 1 addition & 1 deletion base/deprecated.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function depwarn(msg, funcsym)
_id=(frame,funcsym),
_group=:depwarn,
caller=caller,
maxlog=1
maxlog=funcsym === () ? nothing : 1
)
nothing
end
Expand Down