loading: fix two bugs in project file deps parsing + tests #26580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
force-pushed
the
sk/loadfix
branch
from
75706bd
to
897578f
Compare
StefanKarpinski
force-pushed
the
sk/loadfix
branch
from
897578f
to
1eb266b
Compare
|
My thought in #26570 was that it is unnecessary to parse the whole file if you found the name and a new UUID but it probably doesn't matter in practice. |
|
That's true but it only continues parsing until it hits a section or the file ends, so it at most parses the top-matter of the project file in that case. There are other cases where it could exit early when it doesn't find a name at the root or in the deps and there are more sections, but as you say, it probably doesn't matter since these files are not expected to be large. |
|
The important addition here is not even the bug fixes, it's the tests 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a fix for Pkg3 precompile breakage thrown in for kicks. This is my alternative to #26570.