Add deprecation for equalto and occursin #26480
Conversation
ararslan
force-pushed
the
aa/equalto-dep
branch
from
59bc7af
to
d8ef718
Compare
|
I'd remove the NEWS — the context there is breaking changes from 0.6. I think that'd just be confusing for the vast majority of the audience. |
ararslan
force-pushed
the
aa/equalto-dep
branch
2 times, most recently
from
84b6fcf
to
e8f954c
Compare
| @@ -1510,6 +1510,12 @@ end | |||
| # Issue #26248 | |||
| @deprecate conj(x) x | |||
|
|
|||
| # PR #26436 | |||
| @deprecate equalto(x) isequal(x) | |||
| @deprecate(occursin(x), in(x)) | |||
There was a problem hiding this comment.
Otherwise it parses as occursin(x) in x
base/deprecated.jl
Outdated
| @deprecate equalto(x) isequal(x) | ||
| @deprecate(occursin(x), in(x)) | ||
| @deprecate_binding EqualTo Base.Fix2 false | ||
| @deprecate_binding OccursIn Base.Fix2 false |
There was a problem hiding this comment.
I left in definitions for these actually:
const EqualTo = Fix2{typeof(isequal)}
const OccursIn = Fix2{typeof(in)}
I'm not sure what their ultimate fate will be but they're pretty harmless for now.
There was a problem hiding this comment.
The use of OccursIn there will be kind of weird once the contains -> occursin replacement goes through though.
There was a problem hiding this comment.
Fair enough, but we have to do something. They can't both be deprecated just to Fix2, since that won't work.
There was a problem hiding this comment.
Okay, I can just remove these deprecations and we can probably just silently remove EqualTo and OccursIn between 0.7 and 1.0. How does that sound?
There was a problem hiding this comment.
Why not just do @deprecate_binding EqualTo Base.Fix2{typeof(isequal)} false? That seems to work.
There was a problem hiding this comment.
Do we want to make the internal definitions use <:Union{typeof(isequal), typeof(==)}?
Also deprecate the unexported EqualTo and OccursIn aliases (which were previously types before 26436).
ararslan
force-pushed
the
aa/equalto-dep
branch
from
e8f954c
to
71ab218
Compare
These were removed in #26436 without deprecation, so this PR adds a deprecation for them
plus a NEWS item. It also addresses #26436 (comment).