Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to functions in the manual #26171

Merged
merged 2 commits into from
Feb 27, 2018

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Feb 23, 2018

I have used @Ref instead of @ref and links are broken. This PR fixes this.

I have used `@Ref` instead of `@ref` and links are broken. This PR fixes this.
@bkamins
Copy link
Member Author

bkamins commented Feb 23, 2018

CC @vchuravy

@@ -1511,8 +1511,8 @@ For instance functions that have their
[name ending with `!`](https://docs.julialang.org/en/latest/manual/style-guide/#Append-!-to-names-of-functions-that-modify-their-arguments-1)
by convention modify their arguments and thus are not pure. However, there are
functions that have side effects and their name does not end with `!`. For
instance [`findfirst(regex, str)`](@Ref) mutates its `regex` argument or
[`rand()`](@Ref) changes `Base.GLOBAL_RNG` :
instance [`findfirst`](@ref) mutates its `regex` argument or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps keep (regex, str), otherwise what follows does not make any sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed; I was afraid that it was also breaking a link (but I understand it does not).

@fredrikekre fredrikekre merged commit 6354c66 into JuliaLang:master Feb 27, 2018
@bkamins bkamins deleted the patch-18 branch February 27, 2018 20:15
mbauman added a commit that referenced this pull request Mar 5, 2018
…gnment

* master:
  Make stdlib tests runnable standalone. (#26242)
  fix unary-related parsing regressions caused by #26154 (#26239)
  Formatting changes to new SSA IR devdocs [ci skip]
  use medium code model on PPC
  `retry` should support the check function proposed in the docstring. (#26138)
  mention axes in docs instead of size (#26233)
  exclude more CI files from source distro (#25906)
  Describe three-valued logic in docstrings
  deprecate using the value of `.=`. fixes #25954 (#26088)
  backport change to make CodegenPrepare work with isNoopAddrSpaceCast
  optimize the python version of abs2 in the microbenchmarks (#26223)
  Add notes for package maintainers (#25912)
  typo
  Fix broken links to functions in the manual (#26171)
  [NewOptimizer] Track inlining info
  Begin work on new optimizer framework
  add patch to make GC address spaces work on PPC
  also backport sover patch to LLVM 4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants