add a merge method for Pairs of NamedTuple to speed up keyword splatting
#25936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splatting fixes #9551
JeffBezanson
added
performance
ararslan
reviewed
Feb 7, 2018
| @@ -226,6 +226,8 @@ end | |||
|
|
|||
| merge(a::NamedTuple{()}, b::NamedTuple) = b | |||
|
|
|||
| merge(a::NamedTuple, b::Iterators.Pairs{<:Any,<:Any,<:Any,<:NamedTuple}) = merge(a, b.data) | |||
There was a problem hiding this comment.
Do we have an existing test that hits this code path?
There was a problem hiding this comment.
Yes, this is covered by the keywordargs tests.
ararslan
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9551. Well, that was also fixed by #24795, but this re-fixes it.