-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename bytesavailable (née nb_available) to nbytesavailable #25659
Conversation
I don't really buy the need for the |
No strong opinion here. Either is fine with me. |
I also don't really care, but the proponents of |
We seem to use the |
The |
I wonder if there could be a list somewhere of "ok" abbreviations in Julia like number_of_ -> n. Even I'm willing to admit that number_of_available_bytes is a bit of a mouthful. |
It was noted that the `n` provided an important distinction, so this PR adds it for clarity.
1066977
to
ca39a0f
Compare
Correct me if I'm wrong, but I don't think there's any strong opposition to adding the |
I don't really like the |
Triage is fine without the |
In #25634,
nb_available
was renamed tobytesavailable
. However, it was noted that then
provided an important distinction, so this PR adds it for clarity, thus renamingbytesavailable
tonbytesavailable
.This is technically a breaking change, code eagerly updated in the last few hours since #25634 was merged will get an
UndefVarError
frombytesavailable
. I can add a defensive second deprecation if necessary.