Deprecate module querying functions to parentmodule methods #25629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
the
kind:deprecation
|
Ref. #25436, which was born out of discussion that e.g. |
ararslan
force-pushed
the
aa/parentmodule
branch
from
ea05536
to
300ebb6
Compare
StefanKarpinski
approved these changes
Jan 18, 2018
Sacha0
approved these changes
Jan 18, 2018
inkydragon
added a commit
to inkydragon/julia
that referenced
this pull request
Jun 19, 2022
aviatesk
pushed a commit
that referenced
this pull request
Jun 19, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function
parentmoduleand deprecatesmodule_parent,Base.datatype_module, andBase.function_modulein favor ofparentmodulemethods. I find that this has a nice symmetry with the changes made in #25622.