guard against LAPACK least squares solver test failure, round 2 #25418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25287 modified a LAPACK least squares solver test to guard against failure due to poor conditioning of the test matrices. Unfortunately that modification proved insufficient as I ran into the motivating failure again locally
This pull request relaxes the test tolerance just enough for the test to pass 100,000 consecutive repetitions:
(Factors of 2 and 3 rather than 4 were insufficient.) Best!