-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Iterate Factorizations to allow deconstruction #25187
Conversation
2ed2d19
to
b77cb50
Compare
I like it. Or we could just rename |
I'd be fine with either but I think the least disruptive change would be to first deprecate |
That seems like more of a pain since with this change they become interchangeable and you'd want to deprecate the one that you're ultimately going to get rid of, no? |
Perhaps rebase with #25184 in? |
Perhaps worth rebasing over the new iteration protocol? Best! |
This seems useful, but is entirely within LinAlg. If somebody wants to get it in before the feature freeze, that'd be fine, but it's not blocking. |
Some observations relevant to seeing this work through:
|
Perhaps we can close this one in light of recent work? |
As a followup to #25184 I thought I'd open a PR with (inferrable)
Factorization
deconstruction as suggested in #15573 (and maybe other places) which could potentially clean up the linear algebra namespace. For now I've just implemented deconstruction ofLU
such thatlufact
can behave likelu
, i.e.So if we think this is a good idea, we'd be able to deprecate at least
lu
,qr
,eig
, andsvd
.