Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/RFC: Adding EgalDict{K,V} (aka ObjectIdDict{K,V}) #24932

Closed
wants to merge 7 commits into from

Commits on Dec 14, 2017

  1. Configuration menu
    Copy the full SHA
    5ed29a2 View commit details
    Browse the repository at this point in the history
  2. Moved fields of Dict into BaseDict which is wrapped in Dict/EgalDict

    Strange error in test/inference.jl
    mauro3 committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    7818dc7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5ef545e View commit details
    Browse the repository at this point in the history
  4. DRYing the Dicts

    mauro3 committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    dfbf197 View commit details
    Browse the repository at this point in the history
  5. Renamed ObjectIdDict->IdDict and EgalDict->ObjectIdDict

    Internally IdDicts are only used early in the bootstrap.  All other
    instances of ObjectIdDict use my new implementation.
    
    Skipping CIs as I expect tests to fail.  I will force push a working
    commit onto this tomorrow.
    
    [ci skip]
    [av skip]
    [bsd skip]
    mauro3 committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    70d4569 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2017

  1. odd bug

    mauro3 committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    46866da View commit details
    Browse the repository at this point in the history
  2. Strange rehash-bug with doc system

    ?module works
    ?sin does not
    
    rehashing the meta-dicts fixes it
    
    for m in Base.Docs.modules
        Base.rehash!(Base.Docs.meta(m))
    end
    
    Simlarly, there was a rehashing in serialize.jl which was fixed going
    ObjectIdDict->IdDict.  But with the doc-system that did not help.
    
    Skipping some CIs to save resources:
    [ci skip]
    [av skip]
    [bsd skip]
    mauro3 committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    721c394 View commit details
    Browse the repository at this point in the history