loading: refactor .ji loading error handling better #24630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/require_ji_better
branch
from
de71018 to
f72f0b1
Compare
vtjnash
force-pushed
the
jn/require_ji_better
branch
from
f72f0b1 to
922990f
Compare
Member
|
This just broke the build. |
StefanKarpinski
added a commit
that referenced
this pull request
Dec 12, 2017
This reverts commit 82fb32f.
vtjnash
added a commit
that referenced
this pull request
Dec 12, 2017
evetion
pushed a commit
to evetion/julia
that referenced
this pull request
Dec 12, 2017
evetion
pushed a commit
to evetion/julia
that referenced
this pull request
Dec 12, 2017
…Lang#24630)" This reverts commit 82fb32f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some callback code out of C into Julia, where we can do better error handling. And also hopefully makes it easier for Stefan to modify this code in his Pkg3 PR.