eliminate full from test/linalg/symmetric.jl #23896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Sep 27, 2017
| @@ -72,10 +72,6 @@ end | |||
| @test isa(similar(Symmetric(asym), Int, (3,2)), Matrix{Int}) | |||
| @test isa(similar(Hermitian(aherm), Int, (3,2)), Matrix{Int}) | |||
| end | |||
| @testset "full" begin | |||
There was a problem hiding this comment.
Worth keeping in some form? Unless Matrix(S::Symmetric) is tested elsewhere in this file
There was a problem hiding this comment.
Didn't find this explicitly tested so took the liberty to add it.
There was a problem hiding this comment.
Good call, and thanks for the lovely addition! :)
fredrikekre
approved these changes
Sep 27, 2017
|
Thanks all! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small step towards deprecation of
full. Ref. #12153, #12251, #18850, and linked threads. Best!