Experiment for #23770 (Final LibGit2 credential callback changes) #23776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The temporary credential object is independent from any cached or stored credential until it is explicitly approved.
Credentials should be used when they are filled in and alternatives should be tried when they are not. These changes allow use to enable the commented out tests which use invalid credentials.
omus
force-pushed
the
cv/libgit2-experiment
branch
from
19ff472 to
8a99c73
Compare
yuyichao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking #23770 without the "Set error message when auth fails" commit.
Don't bother reviewing this commit.