Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run all -e -E -L commands given, in order #23775

Merged
merged 3 commits into from
Sep 22, 2017
Merged

run all -e -E -L commands given, in order #23775

merged 3 commits into from
Sep 22, 2017

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 19, 2017

fix #23665

StefanKarpinski
StefanKarpinski reviewed Sep 19, 2017
View reviewed changes
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The change to calling display seems good but I feel like one will generally want to have the trailing newline. In case one doesn't, it's still always possible to use -e and call display / show in the expression.

@vtjnash
Copy link
Member Author

vtjnash commented Sep 19, 2017

Yeah, there's just a slight problem that there's no way to display a newline, it would need to be done by the Display.

@StefanKarpinski
Copy link
Member

What's wrong with just calling println?

@vtjnash
Copy link
Member Author

vtjnash commented Sep 19, 2017

It doesn't get written to the Display.

@StefanKarpinski
Copy link
Member

Why does that matter?

@StefanKarpinski
Copy link
Member

There was talk of a pass-through display wrapper type, which would allow display(MIMEData{"text/plain"}("\n")) to express what would be wanted here.

@StefanKarpinski StefanKarpinski merged commit e009ac6 into master Sep 22, 2017
@StefanKarpinski StefanKarpinski deleted the jn/23665 branch September 22, 2017 22:47
iblislin
iblislin reviewed Jan 8, 2018
View reviewed changes
base/options.jl
eval::Ptr{UInt8}
print::Ptr{UInt8}
load::Ptr{UInt8}
commands::Ptr{Ptr{UInt8}} # (e)eval, (E)print, (L)load
Copy link
Member

@iblislin iblislin Jan 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In C struct, this field named as cmds, it's inconsistent.
Is this intended?

@tkf tkf mentioned this pull request Sep 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblislin iblislin iblislin left review comments

@StefanKarpinski StefanKarpinski StefanKarpinski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: all --eval <code> should evaluate
3 participants
@vtjnash @StefanKarpinski @iblislin