LibGit2 credential approval/rejection #23711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I missed a usage of |
omus
force-pushed
the
cv/libgit2-cred-approval
branch
from
219a750 to
cc25af0
Compare
rofinn
suggested changes
Sep 14, 2017
| @@ -45,7 +45,7 @@ function user_abort() | |||
| (Cint, Cstring), | |||
| Cint(Error.Callback), "Aborting, user cancelled credential request.") | |||
|
|
|||
| return Cint(Error.EAUTH) | |||
| return Cint(Error.EUSER) | |||
There was a problem hiding this comment.
Just going to mention that EUSER is a generic error code which is suppose to be for callback usage. It doesn't formally mean the user cancelled the callback.
| @@ -1119,14 +1119,29 @@ struct CachedCredentials <: AbstractCredentials | |||
| CachedCredentials() = new(Dict{String,AbstractCredentials}()) | |||
| end | |||
|
|
|||
| "Obtain the cached credentials for the given host+protocol (credid), or return and store the default if not found" | |||
| get_creds!(collection::CachedCredentials, credid, default) = get!(collection.cred, credid, default) | |||
There was a problem hiding this comment.
Should probably deprecate get_creds! properly.
There was a problem hiding this comment.
Added a proper deprecation for this. It required adding Base.get!(cache::CachedCredentials, cred_id, default). Additionally, I switched the test/misc.jl tests to use get!.
omus
force-pushed
the
cv/libgit2-cred-approval
branch
from
cc25af0 to
93c3dbb
Compare
Differentiates this error from EAUTH exceptions which indicate that the credentials are invalid.
Only save credentials to the cache when they are used successfully. Credentials that trigger an EAUTH exception will be removed from the cache. Note: Modifications to the credential field in the CredentialPayload should not modify cached credentials until they are approved.
Since the credential ID is based upon the URL which couldn't change during the lifetime of a CredentialPayload then we only need to pull a credential out of the cache once.
omus
force-pushed
the
cv/libgit2-cred-approval
branch
from
93c3dbb to
86c6a17
Compare
This was referenced Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the credential callback would mutate the explicitly provided credential or cached credential. With this change we never mutate explicitly provided credentials and only add/replace credentials in the cache when they have successfully been used.
Additionally, this PR lays the ground work for integrating other credential storage systems such as the git credential helpers and removes the LibGit2 function
get_creds!.Part of #20725.